Do not pass garbage values to perf_event_open #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soramichi
force-pushed
the
fix_regs_init
branch
from
7bee105 to
b48cda1
Compare
opcm
requested changes
Nov 30, 2018
Contributor
opcm
left a comment
opcm
left a comment
There was a problem hiding this comment.
thanks a lot for catching this! Please consider suggested changes
opcm
approved these changes
Nov 30, 2018
rdementi
added a commit
that referenced
this pull request
Dec 16, 2021
add silent info option -s to pcm-memory, some additional fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #97.
For processors with 8 general purpose counters,
pcm-core.xsometimes cannot run due to an error:"Linux Perf: Error on programming generic event #0 error: Operation not supported".The reason is that
EventSelectRegister regs[4]has the fixed length of 4, andm->program(...)passes non-initialized garbage values toperf_event_openwhen the number of general purpose counters is more than 4 (by accessingregs[4],regs[5]and beyond).