This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Initialize variables #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the following -Werror=maybe-uninitialized errors:
psm_diags.c:294:10: error: 'dst_p' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (dst_p) psmi_free(dst_p);
^
In file included from psm_user.h:54:0,
from psm_diags.c:35:
psm_utils.h:156:23: error: 'src_p' may be used uninitialized in this function [-Werror=maybe-uninitialized]
#define psmi_free(sz) psmi_free_internal(sz)
^
psm_diags.c:290:11: note: 'src_p' was declared here
void *src_p, *dst_p;
^
If posix_memalign fails to return a value different than zero,
the pointers are never initialized.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the following -Werror=maybe-uninitialized errors:
psm_diags.c:294:10: error: 'dst_p' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (dst_p) psmi_free(dst_p);
^
In file included from psm_user.h:54:0,
from psm_diags.c:35:
psm_utils.h:156:23: error: 'src_p' may be used uninitialized in this function [-Werror=maybe-uninitialized]
#define psmi_free(sz) psmi_free_internal(sz)
^
psm_diags.c:290:11: note: 'src_p' was declared here
void *src_p, *dst_p;
^
If posix_memalign fails to return a value different than zero,
the pointers are never initialized.
I found this problem while updating the Debian package