fix: Temporarily disable host password decryption in create_host_from…#9
Merged
Conversation
…_model Signed-off-by: Lasota, Adrian <adrian.lasota@intel.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Temporarily disables host password decryption during host creation and adds clarifying comments about how password fields are represented in connection options.
Changes:
- Commented out
_decrypt_host_password()increate_host_from_model(). - Added TODO comments clarifying that password fields appear as
SecretStrfrom the model’s perspective even when not encrypted.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mchromin
previously approved these changes
May 19, 2026
Signed-off-by: Lasota, Adrian <adrian.lasota@intel.com>
Contributor
|
We don't publish DEVs .whl. |
mchromin
approved these changes
May 19, 2026
hcymerys
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes minor adjustments related to password handling in the
pytest_mfd_config/fixtures.pyfile. The main changes involve temporarily disabling host password decryption and clarifying the handling of password fields in connection options.Password handling adjustments:
_decrypt_host_passwordin thecreate_host_from_modelfunction, with a note to fix host password decryption in the future._has_secret_password_fieldsfunction to clarify that password fields are alwaysSecretStrfrom the model's perspective, even if not encrypted.