Merged
Conversation
The CPA_H include guard is too generic and risks collisions when the header is included alongside other libraries. Rename it to CPA_QAT_H for a more project-specific guard. Also remove the redundant #ifndef CPA_H conditional wrappers around cpa.h as it has its own include guard to prevent double inclusion. This addresses GitHub issue #139. Signed-off-by: Ahsan Atta <ahsan.atta@intel.com>
gcabiddu
approved these changes
Feb 17, 2026
|
💭 Would you dare to apply even more unique name patterns for affected include guards? |
Contributor
We haven't seen any actual clashes and think this length pattern is sufficient. If that proves not to be the case we can look at implementing your other suggestions in future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CPA_H include guard is too generic and risks collisions when the header is included alongside other libraries. Rename it to CPA_QAT_H for a more project-specific guard.
Also remove the redundant #ifndef CPA_H conditional wrappers around cpa.h as it has its own include guard to prevent double inclusion.
This addresses GitHub issue #139.