Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances solution stop reporting by attaching the triggering exception/breakpoint identifier to the SolutionKind, improving the debug signal when the simulator is stopped due to these events.
Changes:
- Extend
SolutionKind::ExceptionandSolutionKind::Breakpointto include anumber: i64. - Update solution classification matching to handle the new struct-style enum variants.
- Populate the new
numberfield inon_exceptionandon_breakpoint_memopstop reasons.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/state/mod.rs |
Adds numeric context to SolutionKind for exception/breakpoint solutions. |
src/haps/mod.rs |
Updates match arms and stop invocations to construct the new SolutionKind variants with IDs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Wenzel
force-pushed
the
feat/debug-exception-stop-reason
branch
from
8e40311 to
d55ff31
Compare
Wenzel
force-pushed
the
feat/debug-exception-stop-reason
branch
from
d55ff31 to
6dfc450
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.