Skip to content

Conversation

@tyilo
Copy link
Contributor

@tyilo tyilo commented Jun 17, 2024

Without this node-gyp produces the following error when compiling:

C:\wmi-native-module-main\src\wmi_wrapper.cpp(102,27): error C2220: the following warning is treated as an error [C:\wmi-native-module-main\build\wmi_native_module.vcxproj]
C:\wmi-native-module-main\src\wmi_wrapper.cpp(102,27): warning C4018: '<': signed/unsigned mismatch [C:\wmi-native-module-main\build\wmi_native_module.vcxproj]
C:\wmi-native-module-main\src\wmi_wrapper.cpp(365,27): warning C4018: '<': signed/unsigned mismatch [C:\wmi-native-module-main\build\wmi_native_module.vcxproj]
C:\wmi-native-module-main\src\wmi_wrapper.cpp(368,31): warning C4018: '<': signed/unsigned mismatch [C:\wmi-native-module-main\build\wmi_native_module.vcxproj]

@esnyder1 esnyder1 merged commit df545b1 into intel:main Jul 8, 2024
@tyilo
Copy link
Contributor Author

tyilo commented Sep 25, 2024

@esnyder1 Would it be possible to create a release containing this fix?

@esnyder1
Copy link
Contributor

esnyder1 commented Oct 1, 2024

@tyilo We are working on getting a release out this month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants