Skip to content

Updates for v1.0.2 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Updates for v1.0.2 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75d5888
update node-addon-api and set new version
esnyder1 Oct 15, 2024
1f95430
move strings where possible
esnyder1 Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@intelcorp/wmi-native-module",
"version": "1.0.1",
"version": "1.0.2",
"description": "WMI Native Module",
"main": "index.js",
"repository": {
Expand All @@ -11,7 +11,7 @@
"contributors": [],
"license": "MIT",
"dependencies": {
"node-addon-api": "^7.0.0"
"node-addon-api": "^8.2.1"
},
"scripts": {
"install": "node-gyp rebuild"
Expand Down
12 changes: 6 additions & 6 deletions src/wmi_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ namespace wmi_wrapper
for (size_t i = 0; i < properties.size(); ++i)
{
std::wstring value = GetPropertyValue(properties[i], class_object);
(*results).push_back(make_pair(properties[i], std::wstring(value)));
(*results).push_back(make_pair(properties[i], std::wstring(std::move(value))));
}
return hres;
}
Expand Down Expand Up @@ -141,7 +141,7 @@ namespace wmi_wrapper
for (int i = start; i < end; ++i)
{
std::wstring value = GetPropertyValue(names[i], class_object);
(*results).push_back(make_pair(names[i], std::wstring(value)));
(*results).push_back(make_pair(names[i], std::wstring(std::move(value))));
}
hres = SafeArrayUnaccessData(names_array);
return hres;
Expand Down Expand Up @@ -197,7 +197,7 @@ namespace wmi_wrapper
{
object_result = GetAllPropertyValues(class_objects[i], &result);
}
results->push_back(result);
results->push_back(std::move(result));

class_objects[i]->Release();
}
Expand Down Expand Up @@ -342,7 +342,7 @@ namespace wmi_wrapper
{
std::string value = param_value.ToString().Utf8Value();
std::wstring wstr_value = ConvertStringToWstring(value);
wstr_properties.push_back(wstr_value);
wstr_properties.push_back(std::move(wstr_value));
}
else
{
Expand Down Expand Up @@ -433,14 +433,14 @@ namespace wmi_wrapper
WmiQueryParams wstr_params = GetWstrParams(query, properties, env);

std::vector<WmiQueryResult> results;
HRESULT hres = wmi_wrapper::Query(wmi_namespace.Utf8Value().c_str(), wstr_params, &results);
HRESULT hres = wmi_wrapper::Query(wmi_namespace.Utf8Value().c_str(), std::move(wstr_params), &results);
if (FAILED(hres))
{
std::string hresStr = std::to_string(hres);
Napi::Error::New(env, "Query failed with error code: " + hresStr).ThrowAsJavaScriptException();
}

return ConvertResultsObject(results, env);
return ConvertResultsObject(std::move(results), env);
}

Napi::Object Init(
Expand Down