Skip to content
This repository was archived by the owner on Nov 3, 2021. It is now read-only.

Conversation

@MichaelDevenish
Copy link
Contributor

team-edm#14634
image

The following MUST be checked prior to approval. If not relevant to your PR, remove the line from your description.

  • The styleguide.config.js has been updated to show examples/new functionality for the component
  • Test Coverage for any new or updated functionality
  • New and updated components have been tested locally in lapis and SPA and work as expected
  • This PR has been tagged with PATCH, MINOR, or MAJOR.
  • The component has data-component-type and data-component-context attributes following the standard
  • You have requested a cross-team review on this component so everyone knows it exists

@MichaelDevenish MichaelDevenish added the PATCH Bug fixes or improvements with backward compatible changes label Jan 28, 2021
@MichaelDevenish MichaelDevenish requested a review from a team January 28, 2021 04:30
@MichaelDevenish MichaelDevenish self-assigned this Jan 28, 2021
@MichaelDevenish MichaelDevenish added MINOR Extra functionality with backward compatible changes and removed PATCH Bug fixes or improvements with backward compatible changes labels Jan 28, 2021
Copy link
Contributor

@xley xley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thats exactly what I did. Looks good!

@xley xley merged commit f637402 into intellihr:develop Jan 28, 2021
@intellibot-access intellibot-access bot mentioned this pull request Jan 28, 2021
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

MINOR Extra functionality with backward compatible changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants