Skip to content

Conversation

@mkaput
Copy link
Member

@mkaput mkaput commented Apr 23, 2016

No description provided.

@matklad matklad merged commit c236de6 into intellij-rust:master Apr 23, 2016
@mkaput mkaput deleted the trait-body branch April 23, 2016 18:21
@matklad
Copy link
Member

matklad commented Apr 23, 2016

Hm, looks like in the go plugin they do not introduce a special syntactic category for bodies of things. https://github.com/go-lang-plugin-org/go-lang-idea-plugin/blob/58a85af0be6652f1882ba5725588d691af7cd27d/grammars/go.bnf#L168

I guess this will not work for us, because we have rather more involved headers.

@mkaput
Copy link
Member Author

mkaput commented Apr 23, 2016

I find multiple advantages of this solution:

  1. I believe this will make creating indentation fixer easier
  2. Expand selection <3
  3. Kotlin & Java do this

Disadvantage: **Body.foo instead of just foo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants