[LEA-5114] Fixing the issue with using incorrect queue#5
Conversation
…correctly enqueuing job to the correct queue.
|
I've added some reviewers, as this issue is somehow related to the queuing issues we've been experiencing lately, to inform them. @supersujit changes seem good, you don't need to wait too much. @zpatten, regarding your work on migrating all Sidekiq Workers into ActiveJobs, this gem should be changed as well. |
Appreciate the heads up! 🙂 |
There was a problem hiding this comment.
LGTM; only one note, this is calling active job methods on the class so I'm assuming the class is a model in all cases?; if that's invoked against a job class which isn't inherited from active job (ie standard sidekiq class) I don't think it will work as intended. I can do some digging if you want to verify and I'm not 100% but I figured it was worth mentioning.
|
One last note, if it is invoked against the job class it should be easy to do an if/else on its base class and enqueue accordingly depending on if it's active job or og sidekiq. |
|
Thanks @zpatten for the review 👍 |
Issue:
https://intellum.atlassian.net/browse/LEA-5114
This issue was identified because
defaultqueue were flooded and slowed, and there were high priority jobs which got enqueued ondefaultqueue. After investigation we found that the issue is with this gem because its not respecting the queue name passed in parameter.This PR tries to fix this issue by correctly setting the queue name using
set(queue:)method.