Implemented msodde scanning in DOC_INFO. Fixes #875#890
Merged
Conversation
Member
Author
|
@mlodic Is this the correct way to do the task? |
Codecov Report
@@ Coverage Diff @@
## develop #890 +/- ##
============================================
+ Coverage 66.75% 77.65% +10.89%
============================================
Files 95 162 +67
Lines 3706 6185 +2479
Branches 519 889 +370
============================================
+ Hits 2474 4803 +2329
- Misses 941 1018 +77
- Partials 291 364 +73
Continue to review full report at Codecov.
|
mlodic
requested changes
Feb 15, 2022
Member
mlodic
left a comment
There was a problem hiding this comment.
thanks for the PR! the code makes sense. A question: can you share the md5 of the sample you tried?
Member
Author
Here is a link to the file I generated. It's md5sum is |
mlodic
approved these changes
Feb 15, 2022
Member
|
that's great! |
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented msodde scanning in DOC_INFO

Screenshot of test result:
Related issues
closes #875
Type of change
Please delete options that are not relevant.
Checklist
develop_monkeypatch()was used in it's class to apply the necessary decorators.Black,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.Important Rules
Real World Example
Please delete if the PR is for bug fixing.
Otherwise, please provide the resulting raw JSON of a finished analysis (and, if you like, a screenshot of the results). This is to allow the maintainers to understand how the analyzer works.