Skip to content

Remove outdated note regarding ephemeral messages #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2021
Merged

Remove outdated note regarding ephemeral messages #168

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11721dc
Remove outdated note regarding ephemeral messages
anand2312 May 3, 2021
511dfca
Remove logger warning regarding hidden embeds
anand2312 May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions discord_slash/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@ async def send(self,
"""
Sends response of the slash command.

.. note::
- Param ``hidden`` doesn't support embed and file.

.. warning::
- Since Release 1.0.9, this is completely changed. If you are migrating from older version, please make sure to fix the usage.
- You can't use both ``embed`` and ``embeds`` at the same time, also applies to ``file`` and ``files``.
Expand Down Expand Up @@ -186,8 +183,6 @@ async def send(self,
else self.bot.allowed_mentions.to_dict() if self.bot.allowed_mentions else {}
}
if hidden:
if embeds or files:
self._logger.warning("Embed/File is not supported for `hidden`!")
base["flags"] = 64

initial_message = False
Expand Down