Skip to content

Sync OpenAPI specs across all versions#507

Merged
dan0505 merged 1 commit into
mainfrom
sync/from-developer-docs-2026-05-20
May 21, 2026
Merged

Sync OpenAPI specs across all versions#507
dan0505 merged 1 commit into
mainfrom
sync/from-developer-docs-2026-05-20

Conversation

@dan0505
Copy link
Copy Markdown
Contributor

@dan0505 dan0505 commented May 20, 2026

Why?

Sync Preview API spec with internal documentation.

Generated with Claude Code

@dan0505 dan0505 self-assigned this May 20, 2026
@dan0505 dan0505 force-pushed the sync/from-developer-docs-2026-05-20 branch 2 times, most recently from 96b02d3 to 7cb4333 Compare May 21, 2026 08:58
@anubhav-intercom
Copy link
Copy Markdown
Contributor

IC Domain Review — Two findings

1. [Important] PR description says "all version spec files (2.7–2.15 and Preview)" but only descriptions/0/ is changed.

The body claims updates across 10 version files, but the diff only touches descriptions/0/api.intercom.io.yaml (Preview). Either the other versions were already synced separately, or the description is inaccurate. If the intent is to add /secure_mode_secrets and /procedures/.../collect_agent_input to all versions, they're missing from 2.7–2.15.

2. [Advisory] Large structural reordering inflates the diff.

/fin/start, /fin/reply, /help_center/collections, /segments are removed and re-added at different positions in the YAML. Endpoint ordering is functionally irrelevant for OpenAPI, but it turns a ~200 LOC substantive change into 1878 LOC of diff noise. Makes it harder to isolate the actual additions (secure_mode_secrets, collect_agent_input, body_markdown, activity_logs/search corrections).

No internal context issues — clean for a public repo. Spec changes themselves look correct based on the monolith verification in the companion PR (developer-docs#910).

~ Automated via Claude

@dan0505 dan0505 force-pushed the sync/from-developer-docs-2026-05-20 branch 2 times, most recently from 7dcb06b to d37ecce Compare May 21, 2026 11:32
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@dan0505 dan0505 force-pushed the sync/from-developer-docs-2026-05-20 branch from d37ecce to e55757a Compare May 21, 2026 11:35
@dan0505 dan0505 merged commit eb004c3 into main May 21, 2026
2 checks passed
@dan0505 dan0505 deleted the sync/from-developer-docs-2026-05-20 branch May 21, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants