Skip to content

Conversation

@thewheat
Copy link
Contributor

Addressing #128

  • uses getTagCollection instead of suggested getTags for consistency with other existing calls on TagCollection
intercom-java/src/main/java/io/intercom/api/Company.java:    public TagCollection getTagCollection() {
intercom-java/src/main/java/io/intercom/api/Contact.java:    public TagCollection getTagCollection() {
intercom-java/src/main/java/io/intercom/api/User.java:    public TagCollection getTagCollection() {

Sample test run using the new code

image

}

public TagCollection getTagCollection() {
if (tagCollection == null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought initially this was an issue with potential infinite loop but actually the opposite. Mentioned it to @mmartinic and he noted that this is used for list as well as single convos so there could be a case where there are no tags returned for listing class.

Copy link
Member

@choran choran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, nice work, good catch with the check for no tags.
👍

@choran choran merged commit 67a3f37 into master Nov 10, 2017
@thewheat thewheat deleted the timlim/add-conversation-tags branch February 14, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants