Skip to content

Em0ney feature/deeper company queries #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
choran merged 5 commits into from
Sep 27, 2017
Merged

Em0ney feature/deeper company queries #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
65e2230
adding code to fix issue #140 implementing find, delete and listUsers…
em0ney Jun 1, 2017
33182f5
adding tests to cover new capabilities in the company class
em0ney Jun 1, 2017
444a4ec
updating code after realising that the intercom api does not support …
em0ney Jun 1, 2017
d2b2b07
Resolving conflicts for PR #153
choran Sep 27, 2017
7f60ff5
Removing backticks for single quotes where appropriate
choran Sep 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/company.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,21 @@ export default class Company {
return this.client.get('/companies', params, f);
}
find(params, f) {
return this.client.get(`/companies/${params.id}`, {}, f);
if (params.id) {
return this.client.get(`/companies/${params.id}`, {}, f);
} else if (params.company_id) {
return this.client.get('/companies', { company_id: params.company_id }, f);
} else if (params.name) {
return this.client.get('/companies', { name: params.name }, f);
}
}
listUsers(params, f) {
if (params.id) {
return this.client.get(`/companies/${params.id}/users`, {}, f);
} else if (params.company_id) {
return this.client.get(`/companies`, {type: 'user', company_id: params.company_id}, f);
return this.client.get('/companies', { company_id: params.company_id, type: 'user' }, f);
} else if (params.name) {
return this.client.get('/companies', { name: params.name, type: 'user' }, f);
}
}
}
32 changes: 28 additions & 4 deletions test/company.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,28 +27,52 @@ describe('companies', () => {
done();
});
});
it('find companies by id', done => {
it('should find companies by id', done => {
nock('https://api.intercom.io').get('/companies/baz').reply(200, {});
const client = new Client('foo', 'bar').usePromises();
client.companies.find({ id: 'baz' }).then(r => {
assert.equal(200, r.status);
done();
});
});
it('list company users by id', done => {
it('should find companies by company_id', done => {
nock('https://api.intercom.io').get('/companies').query({ company_id: 'baz' }).reply(200, {});
const client = new Client('foo', 'bar').usePromises();
client.companies.find({ company_id: 'baz' }).then(r => {
assert.equal(200, r.status);
done();
});
});
it('should find companies by name', done => {
nock('https://api.intercom.io').get('/companies').query({ name: 'baz' }).reply(200, {});
const client = new Client('foo', 'bar').usePromises();
client.companies.find({ name: 'baz' }).then(r => {
assert.equal(200, r.status);
done();
});
});
it('should list company users by id', done => {
nock('https://api.intercom.io').get('/companies/baz/users').reply(200, {});
const client = new Client('foo', 'bar').usePromises();
client.companies.listUsers({ id: 'baz' }).then(r => {
assert.equal(200, r.status);
done();
});
});
it('list company users by company_id', done => {
nock('https://api.intercom.io').get('/companies').query({type: 'user', company_id: 'baz'}).reply(200, {});
it('should list company users by company_id', done => {
nock('https://api.intercom.io').get('/companies').query({ company_id: 'baz', type: 'user' }).reply(200, {});
const client = new Client('foo', 'bar').usePromises();
client.companies.listUsers({ company_id: 'baz' }).then(r => {
assert.equal(200, r.status);
done();
});
});
it('should list company users by company name', done => {
nock('https://api.intercom.io').get('/companies').query({ name: 'baz', type: 'user' }).reply(200, {});
const client = new Client('foo', 'bar').usePromises();
client.companies.listUsers({ name: 'baz' }).then(r => {
assert.equal(200, r.status);
done();
});
});
});