Skip to content

Conversation

@lucianocn
Copy link

@lucianocn lucianocn commented Mar 21, 2017

Reference: Issue #205

@kant01ne
Copy link
Contributor

kant01ne commented Jun 7, 2017

Sorry for taking so long to review this @lucianocn
Nice work 👍 Would be great to have it tested in IntercomClientTest.
Let me know if you want to add it. If not I'll be happy to take a look whenever I have some time.

@choran
Copy link
Member

choran commented Aug 29, 2017

Hi @lucianocn
Just checking in to see if you got any chance to add a test for this?
We can try and add it also but just wanted to check with you in the meantime

choran added a commit that referenced this pull request Sep 14, 2017
* improved .gitignore

* added extraGuzzleRequestsOptions (optional) to IntercomClient

* avoid $extraGuzzleRequestsOptions errors

* typo fixes

* Adding unit test for PR #206 and fixing unit test from previous PR

* Removing misc print and setting test timezone to UTC

* Fixing issue with CI test failing
@choran
Copy link
Member

choran commented Sep 14, 2017

Hi @lucianocn
Just closing this since added unit test for this in separate PR #232 and merged changes via that PR

@choran choran closed this Sep 14, 2017
@lucianocn
Copy link
Author

@Skaelv @choran sorry for my delay! Nice job guys ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants