Added support of version 2+ of php-http/client-common #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Bonvarlet <julien.bonvarlet@meero.com>
Contributor
|
Hi @tyloo 👋 Thank you for this PR! When this was introduced, I'll have a second look at the changelog to ensure we are not using any of the changed features and merge it as soon as possible 😃 |
Contributor
Author
|
@GabrielAnca : any updates sir? |
GabrielAnca
approved these changes
Jul 29, 2019
Contributor
GabrielAnca
left a comment
GabrielAnca
left a comment
There was a problem hiding this comment.
Hey @tyloo, sorry I didn't have time to have a look on Friday. It looks perfect, ran some tests locally and it works perfectly with both versions. Thank you so much for this! 🙇
Contributor
|
Merged and new version 4.0.3 created. It might take a while to show up in Packagist 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Breaks compatibility with other packages requiring
php-http/client-commonAnd bump version to 4.0.3 please ;)
Fixes #279