Skip to content

Update README.md #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GabrielAnca merged 1 commit into from
Jul 28, 2020
Merged

Update README.md #309

GabrielAnca merged 1 commit into from
Jul 28, 2020

Conversation

@GabrielAnca
Copy link
Contributor

@GabrielAnca GabrielAnca commented Jul 22, 2020

We generally name the IntercomClient instance $client in the docs. Update the readme to be consistent.

@GabrielAnca GabrielAnca merged commit d74376e into master Jul 28, 2020
@GabrielAnca GabrielAnca deleted the ga/update-readme-client-variable-name branch July 28, 2020 09:38
SeanHealy33
SeanHealy33 reviewed Jul 28, 2020
View reviewed changes
Copy link
Contributor

@SeanHealy33 SeanHealy33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SeanHealy33 SeanHealy33 SeanHealy33 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GabrielAnca @SeanHealy33