Login user with actual attributes #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
loginUserWithUserAttributesto useIntercomAttributesBuilderwhen passing in additional attributes for a new user, just asupdateUserdoes. This is iOS only as I haven't updated the Android method yet.The parameter typing on
loginUserWithUserAttributesshows the fullUserAttributesobject, but the underlying methods only retainuserIdandemailand discard the rest, which is confusing when passing in additional data and not seeing it on the dashboard. Previously this also required two round-trips, one for initial login and another to update the created user's attributes.If this isn't the desired behavior I'd be happy to instead update the
loginUserWithUserAttributestypes to require onlyuserIdoremail.