Skip to content

Conversation

@dburdan
Copy link
Contributor

@dburdan dburdan commented Jan 8, 2024

This PR updates loginUserWithUserAttributes to use IntercomAttributesBuilder when passing in additional attributes for a new user, just as updateUser does. This is iOS only as I haven't updated the Android method yet.

The parameter typing on loginUserWithUserAttributes shows the full UserAttributes object, but the underlying methods only retain userId and email and discard the rest, which is confusing when passing in additional data and not seeing it on the dashboard. Previously this also required two round-trips, one for initial login and another to update the created user's attributes.

If this isn't the desired behavior I'd be happy to instead update the loginUserWithUserAttributes types to require only userId or email.

Copy link
Contributor

@Br1an-Boyle Br1an-Boyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍🏻

@Br1an-Boyle Br1an-Boyle merged commit bb6cb03 into intercom:main Jan 16, 2024
@dburdan dburdan deleted the dac/loginUserWithAttributes branch January 16, 2024 16:58
uddish pushed a commit that referenced this pull request Mar 13, 2024
* Include passed attrs with loginUserWithUserAttributes

* Remove comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants