Remove incorrect note from add event listener method #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Br1an-Boyle
approved these changes
May 28, 2024
josh-
force-pushed
the
update-add-event-listener-docs
branch
from
50fd09f to
d36252a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
addEventListenerdocumentation states that the method is only for Android, however this method is supported on iOS when using theIntercomUnreadConversationCountDidChangeNotificationevent (docs in README here).We've verified this locally, as such this PR removes this comment from the method documentation, and also updates the documentation to remove references to the outdated
IntercomUnreadCountDidChangeevent type (which is not listed as a possible event type in the README)