fix: correct config chaining in withIntercomPushNotification PR#383
Open
Rosie-Kennelly-1 wants to merge 1 commit intomainfrom
Open
fix: correct config chaining in withIntercomPushNotification PR#383Rosie-Kennelly-1 wants to merge 1 commit intomainfrom
Rosie-Kennelly-1 wants to merge 1 commit intomainfrom
Conversation
The exported plugin was passing the original `config` to both `appDelegate` and `infoPlist` instead of the chained `newConfig`, which meant each plugin received the unmodified config rather than the result of the previous plugin in the chain. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rosie-Kennelly-1
changed the title
Rosie-Kennelly-1
changed the title
liutingdu
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
towards: https://github.com/intercom/intercom/issues/360467
withIntercomPushNotificationpasses the originalconfigto each sub-plugin instead of the chained result, so modifications from earlier plugins in the chain are silently dropped.How?
Pass
newConfiginstead ofconfigso each plugin receives the output of the previous one.Split out from:
#384
#385
Generated with Claude Code