Skip to content

Conversation

@thenickcox
Copy link
Contributor

Why?

The docs contain an incorrect call for tagging companies. The hash key should be company_id, not id. Passing id as a key throws an error.

How?

Changed the hash key.

@thenickcox thenickcox changed the title Change name of hash key in tagging docs Use correct hash key in tagging docs Aug 23, 2018
Copy link
Contributor

@SeanHealy33 SeanHealy33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@choran choran added the ruby label Sep 12, 2018
Copy link
Member

@choran choran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👍

@choran choran merged commit 5519a12 into intercom:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants