Adding clearer instructions for find_all with contacts #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanHealy33
reviewed
Sep 3, 2018
| # Iterate over all conversations for a user with their Intercom user ID | ||
| intercom.conversations.find_all(intercom_user_id: '536e564f316c83104c000020', type: 'user').each {|convo| ... } | ||
| # Iterate over all conversations for a lead | ||
| # NOTE: to iterate over a lead's conversations you MUST use their Intercom User ID and type User |
Contributor
There was a problem hiding this comment.
you can bold by adding double asterix if you feel that would make the MUST stand out more
Contributor
Author
There was a problem hiding this comment.
Can you do that in something commented out?
I don't really think it's a big deal tbf 😛
Contributor
There was a problem hiding this comment.
I didn't realize this was in backticks NVM 😒
SeanHealy33
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
It isn't clear right now how to find_all a contact's conversations, as demonstrated in this issue #422
How?
This adds more concreted examples to the README on how to find contacts conversations.