Skip to content

Conversation

@josler
Copy link
Contributor

@josler josler commented Feb 25, 2014

cc @dehora

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be made required

# Optionally, a created timestamp may be supplied, otherwise the current time in UTC will be used.

@dehora
Copy link
Contributor

dehora commented Feb 25, 2014

Looks good, added some comments on

  • whether the version number should get bumped to 0.2.x
  • default created time
  • examples in rdoc
  • default an event type

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

params[:created] ||= Time.now.utc

Does this replace a created time if I pass one in?

@dehora
Copy link
Contributor

dehora commented Feb 25, 2014

🚀

josler added a commit that referenced this pull request Feb 26, 2014
@josler josler merged commit 13d7c47 into master Feb 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants