fix: use smpclient upstream mtu defaults #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the 4,096B serial MTU default that Intercreate tends to use internally for fast FW updates or file transfers, and removes the 1,024B UDP MTU.
As more people are using smpmgr, the assumption that users would like to default their USB transport for fast upload/download is leading to preventable frustrations. Some devices, like iFixit FixHub, will see FW upgrade upload speeds drop from ~50KBps to ~10KBps with these defaults (users can provide
--mtu 4096to fix), but we don't expect regular users to be impacted since the vast majority use iFixit-provided SW for FW upgrades. That SW knows the correct buffer sizes for fast USB transfers.To get better "out of the box" compatibility, this PR defers defaults to smpclient, which in turn gets its transport defaults from Zephyr's upstream default KConfigs: https://docs.zephyrproject.org/latest/kconfig.html.
Here are some related issues and discussions: