feat: image format --bypass -> --format option#94
Merged
JPHutchins merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
JPHutchins
requested review from
aldenhaase,
Copilot,
davedesro,
intercreate-gab,
kylermconnelly,
robhelvestine and
swoisz
There was a problem hiding this comment.
Pull request overview
This PR replaces the former --bypass-inspect flag with a more flexible --format option (mcuboot vs any) for firmware uploads/upgrades, while also updating the supported Python/runtime/dependency baseline to align with newer smpclient/typer releases.
Changes:
- Introduces
--format {mcuboot,any}and updatesupgrade/image uploadflows to either locally inspect MCUboot images or skip inspection. - Updates dependency requirements (notably
smpclientv7 andtyperv0.24) and bumps the minimum Python version to 3.11. - Removes Python 3.10 from CI matrices.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
smpmgr/main.py |
Switches upgrade from --bypass-inspect to --format, using local MCUboot TLV parsing only when applicable. |
smpmgr/image_management.py |
Adds ImageFormat/ImageFormatOption and updates image upload to honor --format for local inspection behavior. |
pyproject.toml |
Bumps Python requirement to >=3.11 and updates smpclient/typer dependency constraints. |
poetry.lock |
Refreshes the lockfile to reflect updated dependency versions and extras. |
.github/workflows/test.yaml |
Removes Python 3.10 from the test matrix. |
.github/workflows/lint.yaml |
Removes Python 3.10 from the lint matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JPHutchins
force-pushed
the
feature/various-bootloader-image-formats
branch
from
b8ceef1 to
50133f6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI @axelnxp
More flexibility for zephyrproject-rtos/zephyr#103999 and zephyrproject-rtos/zephyr#104691
Image inspection and parsing will be added after some breaking changes and reworks. E.g.
smpmgr image <my_file.bin>can parse and display information about an image file.Users wanting inspection of mcuboot images can use the
mcuimgapp included withsmpclient.We're dropping python 3.10 but I don't consider it breaking since this is an app, not a lib. 3.10 is EOL in 6 months anyway.