script: verification of vault capacity migration#569
Merged
Conversation
daniel-savu
reviewed
Feb 22, 2023
| let n = JSON.stringify(vaultJSON.secureCollateralThreshold).includes("null"); | ||
|
|
||
| let vaultId = vaultJSON.id; | ||
| let collateral = new BN((await apiAt.query.vaultStaking.totalCurrentStake(0, vaultId)).toString()); |
Contributor
There was a problem hiding this comment.
I can't see where the capacity pool stake is queried, is it this one?
Member
Author
There was a problem hiding this comment.
Capacity pool stake is not queried at all. The script outputs the expected capacity stakes, and then you need to manually compare that to the migrated storage
daniel-savu
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script is quite ugly in places but I didn't want to spend time on making it prettier. Committing because it might be useful in hacking together future scripts