fix: better oci handling#18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of Helm chart repository URLs by ensuring that scheme-less OCI registry URLs are normalized to use the
oci://scheme, matching the expectations of the Helm CLI and ArgoCD ApplicationSets. It introduces a normalization function, updates the chart rendering logic to use it, and adds comprehensive unit tests to verify the new behavior.Repository URL normalization:
normalizeRepoURLfunction inutils.goto canonicalize ApplicationSetrepoURLvalues, ensuring that scheme-less OCI registry URLs are prepended withoci://, while existinghttp://,https://, andoci://schemes are preserved. This prevents Helm CLI errors and aligns with ArgoCD's behavior.engine_chart_rendering.goto normalizechart.RepoURLbefore invoking Helm, ensuring consistent handling of repository URLs.Testing improvements:
TestNormalizeRepoURLinutils_test.goto cover various input cases fornormalizeRepoURL, including empty strings, whitespace, explicit schemes, and scheme-less URLs.TestRenderOCIRepoNoSchemeinengine_chart_rendering_test.goto verify that scheme-less OCI URLs are normalized and used correctly in Helm commands during chart rendering.