Merged
Conversation
Deployment results
Logs #18392357623 |
sidvishnoi
reviewed
Oct 8, 2025
frontend/app/components/redesign/components/header/NavDropdown.tsx
Outdated
Show resolved
Hide resolved
sidvishnoi
reviewed
Oct 8, 2025
frontend/app/components/redesign/components/header/NavDropdown.tsx
Outdated
Show resolved
Hide resolved
sidvishnoi
reviewed
Oct 8, 2025
frontend/app/components/redesign/components/header/NavDropdown.tsx
Outdated
Show resolved
Hide resolved
sidvishnoi
changed the title
sidvishnoi
reviewed
Oct 9, 2025
frontend/app/components/redesign/components/header/NavDropdown.tsx
Outdated
Show resolved
Hide resolved
sidvishnoi
approved these changes
Oct 9, 2025
sidvishnoi
approved these changes
Oct 9, 2025
DarianM
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #313
Main website counterpart: WICG/webmonetization#594
Updates the
NavDropdowncomponentVisual and UX improvements:
developer-icon.png,publishers-icon.png,supporters-icon.png) with new active/inactive images for each menu item, enabling visual feedback on hover.ToolsMenuItemcomponent to support both active and inactive imagesLayout and styling adjustments:
md:w-maxinstead of a fixed width, making the dropdown more responsive.groupclass from the dropdown list item to clean up markup.