Skip to content

fix(app): use fieldset and correct label markup for inputs#403

Merged
sidvishnoi merged 7 commits intomainfrom
InputContainer
Oct 11, 2025
Merged

fix(app): use fieldset and correct label markup for inputs#403
sidvishnoi merged 7 commits intomainfrom
InputContainer

Conversation

@sidvishnoi
Copy link
Copy Markdown
Member

Part of #218

Base automatically changed from widget-builder to main October 9, 2025 11:52
@sidvishnoi sidvishnoi marked this pull request as ready for review October 9, 2025 12:37
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

Deployment results

Worker Alias URL Outcome
API - staging success
CDN - staging success
App - 2e36b304 success

Logs #18426756120

Copy link
Copy Markdown
Collaborator

@kjmitchelljr kjmitchelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏿!

)
}

function ContentBuilder({ onRefresh }: Props) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of the components within ContentBuilder need fieldsets applied?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both TitleInput and DescriptionInput are already fieldset/role=group

@sidvishnoi sidvishnoi merged commit 7364831 into main Oct 11, 2025
5 checks passed
@sidvishnoi sidvishnoi deleted the InputContainer branch October 11, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants