Skip to content

chore: upgrade to node v24 (#3854)#3856

Merged
mkurapov merged 1 commit intointerledger:mainfrom
oaripay:main
Mar 24, 2026
Merged

chore: upgrade to node v24 (#3854)#3856
mkurapov merged 1 commit intointerledger:mainfrom
oaripay:main

Conversation

@Mwni
Copy link
Copy Markdown
Contributor

@Mwni Mwni commented Mar 5, 2026

Changes proposed in this pull request

  • Update .nvmrc
  • Update engines in root package.json
  • Update @types/node package
  • Update all Dockerfiles to use node:24-alpine3.23
  • Update workflows/rafiki/env-setup/action.yml to use Node 24
  • Fix Invalid URL error (new URL("")) by filtering empty env string arrays

Context

This change updates Rafiki to Node 24 as the supported runtime across local development, CI, and containerized services.

While upgrading, Node 24 surfaced stricter URL/input behavior and type expectations in HTTP mocks. This PR includes targeted fixes so existing configuration parsing and tests continue to work under the new runtime.

fixes #3854

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

- Update .nvmrc
- Update engines in root package.json
- Update @types/node package
- Update all Dockerfiles to use node:24-alpine3.23
- Update workflows/rafiki/env-setup/action.yml to use Node 24
- Fix Invalid URL error (new URL("")) by filtering empty env string arrays
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 5, 2026

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit d95990e
🔍 Latest deploy log https://app.netlify.com/projects/brilliant-pasca-3e80ec/deploys/69b5379a0f573b0008b7dc3e

@github-actions github-actions Bot added type: ci Changes to the CI type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: auth Changes in the GNAP auth package. pkg: mock-ase pkg: mock-account-service-lib labels Mar 5, 2026
@mkurapov mkurapov self-requested a review March 6, 2026 22:06
Comment thread packages/backend/src/app.ts Outdated
loggingPlugin,
ApolloServerPluginDrainHttpServer({ httpServer })
],
stopOnTerminationSignals: false,
Copy link
Copy Markdown
Contributor

@mkurapov mkurapov Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, let's do the same for the auth package (in packages/auth/src/app.ts)

Copy link
Copy Markdown
Contributor Author

@Mwni Mwni Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this was not meant for this PR, I pushed to my main forgetting I had this PR open. I'll withdraw it. I'll make a separate PR for it once this one is merged.

@mkurapov
Copy link
Copy Markdown
Contributor

Thank you for the contribution @Mwni!

@mkurapov mkurapov merged commit c44d028 into interledger:main Mar 24, 2026
71 of 111 checks passed
@bibschan
Copy link
Copy Markdown
Member

@Mwni thank you for this contribution 🫶🏻 I'd love to personally welcome you in our Interledger Slack community workspace, where you can ask questions, meet the team and find other ways to contribute and claim prizes (we have a 'scavenger hunt' activity happening next week with swag up for grabs!).

Here's the link to join us: https://communityinviter.com/apps/interledger/interledger-working-groups-slack hope to see you there and feel free to DM me! I'm Bibi Souza in there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: ci Changes to the CI type: source Changes business logic type: tests Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade project to Node 24

3 participants