Skip to content

feat: add simplified flow for http-ilp#319

Closed
michielbdejong wants to merge 2 commits intomj-pay-headerfrom
mj-streaming-payments
Closed

feat: add simplified flow for http-ilp#319
michielbdejong wants to merge 2 commits intomj-pay-headerfrom
mj-streaming-payments

Conversation

@michielbdejong
Copy link
Copy Markdown
Contributor

No description provided.

As @sharafian correctly remarked, there is nothing "streaming" about this flow in the POST case (even though the http content does flow in the GET case), so renaming it to "simplified"
@michielbdejong michielbdejong changed the title feat: add streaming flow for http-ilp feat: add simplified flow for http-ilp Oct 25, 2017
michielbdejong pushed a commit to interledger-deprecated/tutorials that referenced this pull request Oct 25, 2017
Copy link
Copy Markdown

@sharafian sharafian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense in theory, but let's hold off on putting it into the actual spec until we're using it in implementation. Otherwise someone who wants to implement a tool for ILP HTTP might read this section and get confused

@michielbdejong
Copy link
Copy Markdown
Contributor Author

OK, but we're already using this to achieve streaming payments in the tutorials, so what should we do about that, then?

@adrianhopebailie
Copy link
Copy Markdown
Collaborator

into the actual spec until we're using it in implementation.

Not sure I agree. These specs are supposed to be drafts of ideas looking for feedback. We shouldn't hold anything back.

The best way to get feedback is make the ideas public and gather experience from implementors.

Right now this whole IL RFC is "invisible" because no version has ever been merged into master. I think that is a mistake.

@sharafian
Copy link
Copy Markdown

I'm also not sure what the advantage of this is as compared to the existing HTTP ILP flow. Are you proposing that implementations should include both or should there be two incompatible HTTP ILP flows described here?

@michielbdejong
Copy link
Copy Markdown
Contributor Author

I'm also not sure what the advantage of this is as compared to the existing HTTP ILP flow

Try out https://interledger.org/tutorials/trustlines and you'll see that it streams hundreds of letters per second, as the response body of one single (streamed) http GET request.

Doing that with the existing HTTP ILP flow would require a lot of individual http GET requests, one for each letter, right? That would be a lot of overhead, so avoiding that overhead is the advantage.

@michielbdejong
Copy link
Copy Markdown
Contributor Author

I guess this is now no longer an Interledger-only question, maybe we should discuss the Pay header on https://lists.w3.org/Archives/Public/ietf-http-wg/2017OctDec/0118.html. Will ask @adrianhopebailie for advice about this.

@michielbdejong
Copy link
Copy Markdown
Contributor Author

michielbdejong commented Nov 7, 2017

@sharafian in the meantime, do you now at least see the advantage of this as compared to the existing HTTP ILP flow? So can we merge this? If not, then let's schedule a 1:1 chat about this.

@michielbdejong
Copy link
Copy Markdown
Contributor Author

Merging this in to #329, will reopen as a PR once discussion reaches a consensus.

@adrianhopebailie adrianhopebailie deleted the mj-streaming-payments branch August 14, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants