This repository was archived by the owner on Mar 2, 2021. It is now read-only.
WIP Feature/payments (handle stripe charges) #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4www
changed the title
added 10 commits
August 13, 2017 10:29
4www
changed the title
Author
|
Ok this is almost ready. Missing:
|
Author
|
Rules seems to work, even when logged in |
oskarrough
reviewed
Aug 20, 2017
src/app.js
Outdated
|
|
||
| admin.initializeApp({ | ||
| credential: admin.credential.cert(serviceAccount), | ||
| databaseURL: "https://radio4000-staging.firebaseio.com" |
Member
There was a problem hiding this comment.
Let's make another file that exports the current databaseURL?
We can use it above ^ and here: https://github.com/internet4000/radio4000-api/blob/master/src/app.js#L27
package.json
Outdated
| "deploy-api": "firebase use api; firebase deploy --only functions", | ||
| "deploy-rules": "firebase use production; firebase deploy --only rules" | ||
| "deploy-rules": "firebase use staging; firebase deploy --only database", | ||
| "deploy-rules-production": "firebase use production; firebase deploy --only rules" |
Member
There was a problem hiding this comment.
shouldn't both the rules scripts use --database? Seems --rules is the old way to do it.
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "cors": "^2.8.4", | ||
| "firebase": "^4.3.0" |
Member
There was a problem hiding this comment.
since these deps are for our app they should be moved to src/package.json. Also, is firebase needed? there is already firebase-admin.
added 9 commits
August 30, 2017 20:02
4www
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend handles Stripe payments, receives a token, and passes it tothe backend (firebase function with express).
chargeto stripechannelmodel toisPremium: true