Skip to content

fix: double hops#409

Merged
NGTmeaty merged 1 commit intomainfrom
double-hops
Jul 30, 2025
Merged

fix: double hops#409
NGTmeaty merged 1 commit intomainfrom
double-hops

Conversation

@yzqzss
Copy link
Copy Markdown
Collaborator

@yzqzss yzqzss commented Jul 30, 2025

close: #392

This bug doesn't do any harm. The extractOutlinks() overrides Hops, so nothing happens.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.67%. Comparing base (af5c533) to head (5d76d59).
⚠️ Report is 124 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/postprocessor/outlinks.go 0.00% 1 Missing ⚠️
...ernal/pkg/postprocessor/sitespecific/reddit/api.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
+ Coverage   51.66%   51.67%   +0.01%     
==========================================
  Files         115      115              
  Lines        7131     7129       -2     
==========================================
  Hits         3684     3684              
+ Misses       3154     3152       -2     
  Partials      293      293              
Flag Coverage Δ
e2etests 29.29% <0.00%> (+<0.01%) ⬆️
unittests 30.32% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@NGTmeaty NGTmeaty merged commit 22c2071 into main Jul 30, 2025
5 checks passed
@NGTmeaty NGTmeaty deleted the double-hops branch July 30, 2025 05:03
@yzqzss yzqzss added the bug Something isn't working label Aug 22, 2025
@yzqzss yzqzss added the GSoC label Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working GSoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double Hops increment for reddit.ExtractAPIPostPermalinks

3 participants