Skip to content

Move reddit.com asset URL fix to SanitizeAssetsOutlinks#416

Merged
NGTmeaty merged 1 commit intointernetarchive:mainfrom
vbanos:fix-reddit
Aug 12, 2025
Merged

Move reddit.com asset URL fix to SanitizeAssetsOutlinks#416
NGTmeaty merged 1 commit intointernetarchive:mainfrom
vbanos:fix-reddit

Conversation

@vbanos
Copy link
Copy Markdown
Collaborator

@vbanos vbanos commented Aug 8, 2025

Addressing issue #397

Also add unit test.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.59%. Comparing base (dc1cc5b) to head (38a2abd).
⚠️ Report is 120 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/postprocessor/assets.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   55.17%   55.59%   +0.42%     
==========================================
  Files         117      119       +2     
  Lines        7257     7301      +44     
==========================================
+ Hits         4004     4059      +55     
+ Misses       2935     2919      -16     
- Partials      318      323       +5     
Flag Coverage Δ
e2etests 37.42% <0.00%> (-0.18%) ⬇️
unittests 31.97% <66.66%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NGTmeaty NGTmeaty merged commit 7a7d63d into internetarchive:main Aug 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants