Skip to content

Simplify HTML extractor logging#417

Merged
NGTmeaty merged 1 commit intointernetarchive:mainfrom
vbanos:html-extractor-simplify
Aug 10, 2025
Merged

Simplify HTML extractor logging#417
NGTmeaty merged 1 commit intointernetarchive:mainfrom
vbanos:html-extractor-simplify

Conversation

@vbanos
Copy link
Copy Markdown
Collaborator

@vbanos vbanos commented Aug 8, 2025

Define url and item once on logger init instead of calling them on each Warn and Debug call.

Define `url` and `item` once on logger init instead of calling theme on
each `Warn` adn `Debug` call.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.51%. Comparing base (dc1cc5b) to head (56a4dc9).
⚠️ Report is 120 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/postprocessor/extractor/html.go 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   55.17%   55.51%   +0.34%     
==========================================
  Files         117      119       +2     
  Lines        7257     7304      +47     
==========================================
+ Hits         4004     4055      +51     
+ Misses       2935     2926       -9     
- Partials      318      323       +5     
Flag Coverage Δ
e2etests 37.43% <20.00%> (-0.16%) ⬇️
unittests 31.88% <20.00%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NGTmeaty NGTmeaty merged commit 6b9d11d into internetarchive:main Aug 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants