Skip to content

Simplify Preprocessor logging#419

Merged
NGTmeaty merged 1 commit intointernetarchive:mainfrom
vbanos:preprocessor-simplify
Aug 10, 2025
Merged

Simplify Preprocessor logging#419
NGTmeaty merged 1 commit intointernetarchive:mainfrom
vbanos:preprocessor-simplify

Conversation

@vbanos
Copy link
Copy Markdown
Collaborator

@vbanos vbanos commented Aug 8, 2025

Define seed_id once on logger init instead of calling it on each logger call.

Also, there was a redundant "func": "preprocessor.preprocess which wasn't necessary as we already define that in the component field of the logger.

Define seed_id once on logger init instead of calling it on each logger call.

Also, there was a redundant `"func": "preprocessor.preprocess` which
wasn't necessary as we already define that in the `component` field of
the logger.
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.56%. Comparing base (dc1cc5b) to head (403762e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/preprocessor/preprocessor.go 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   55.17%   55.56%   +0.39%     
==========================================
  Files         117      119       +2     
  Lines        7257     7301      +44     
==========================================
+ Hits         4004     4057      +53     
+ Misses       2935     2919      -16     
- Partials      318      325       +7     
Flag Coverage Δ
e2etests 37.47% <14.28%> (-0.12%) ⬇️
unittests 31.86% <0.00%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NGTmeaty NGTmeaty merged commit 5b5199f into internetarchive:main Aug 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants