Skip to content

Simplify postprocessor logging#424

Merged
NGTmeaty merged 2 commits intointernetarchive:mainfrom
vbanos:postprocess-logging
Aug 12, 2025
Merged

Simplify postprocessor logging#424
NGTmeaty merged 2 commits intointernetarchive:mainfrom
vbanos:postprocess-logging

Conversation

@vbanos
Copy link
Copy Markdown
Collaborator

@vbanos vbanos commented Aug 11, 2025

Define item_id once on logger init instead of calling it on each logger call.

Define `item_id` once on logger init instead of calling it on each
logger call.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 32.25806% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.56%. Comparing base (dd277b0) to head (cca096e).
⚠️ Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/postprocessor/item.go 33.33% 12 Missing ⚠️
internal/pkg/postprocessor/assets.go 30.76% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   55.54%   55.56%   +0.01%     
==========================================
  Files         119      119              
  Lines        7289     7291       +2     
==========================================
+ Hits         4049     4051       +2     
  Misses       2916     2916              
  Partials      324      324              
Flag Coverage Δ
e2etests 37.55% <29.03%> (+0.03%) ⬆️
unittests 31.86% <9.67%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

NGTmeaty
NGTmeaty previously approved these changes Aug 12, 2025
Copy link
Copy Markdown
Collaborator

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Copy Markdown
Collaborator

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@NGTmeaty NGTmeaty merged commit 064e4d5 into internetarchive:main Aug 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants