Redundant newItem.SetStatus(models.ItemFresh)#425
Merged
NGTmeaty merged 1 commit intointernetarchive:mainfrom Aug 12, 2025
Merged
Redundant newItem.SetStatus(models.ItemFresh)#425NGTmeaty merged 1 commit intointernetarchive:mainfrom
NGTmeaty merged 1 commit intointernetarchive:mainfrom
Conversation
When we create a new item via `NewItem` or `NewItemWithID`, we set status as `ItemFresh` in the constructor. So, it is not necessary to set it again.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
=======================================
Coverage ? 55.57%
=======================================
Files ? 119
Lines ? 7313
Branches ? 0
=======================================
Hits ? 4064
Misses ? 2925
Partials ? 324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NGTmeaty
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we create a new item via
NewItemorNewItemWithID, we set status asItemFreshin the constructor.So, it is not necessary to set it again.