Remove multiple redundant log.Start()#431
Merged
NGTmeaty merged 1 commit intointernetarchive:mainfrom Aug 13, 2025
Merged
Conversation
We keep `log.Start()` in the pipeline where all components are initialized and remove every other `log.Start()` call. Using `log.Start()` multiple times doesn't have any effect since it uses `sync.Once` to run log init only once.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
- Coverage 55.56% 55.09% -0.47%
==========================================
Files 119 119
Lines 7291 7284 -7
==========================================
- Hits 4051 4013 -38
- Misses 2916 2947 +31
Partials 324 324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NGTmeaty
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We keep
log.Start()in the pipeline where all components are initialized and remove every otherlog.Start()call.Using
log.Start()multiple times doesn't have any effect since it usessync.Onceto run log init only once.