Skip to content

Modernize code#433

Merged
CorentinB merged 1 commit intointernetarchive:mainfrom
CorentinB:1.25-modernize
Aug 14, 2025
Merged

Modernize code#433
CorentinB merged 1 commit intointernetarchive:mainfrom
CorentinB:1.25-modernize

Conversation

@CorentinB
Copy link
Copy Markdown
Collaborator

Well it's quite a vague title but I basically just ran go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./....

@CorentinB CorentinB requested review from equals215 and yzqzss August 14, 2025 10:04
@CorentinB CorentinB self-assigned this Aug 14, 2025
@CorentinB CorentinB added the enhancement New feature or request label Aug 14, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.87%. Comparing base (c105a01) to head (6f7c702).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/ui/stats.go 0.00% 3 Missing ⚠️
internal/pkg/postprocessor/sitespecific/ina/ina.go 0.00% 2 Missing ⚠️
internal/pkg/stats/stats.go 0.00% 2 Missing ⚠️
internal/pkg/controler/watchers/warc.go 50.00% 1 Missing ⚠️
internal/pkg/reactor/state.go 50.00% 1 Missing ⚠️
internal/pkg/ui/pause.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   54.77%   54.87%   +0.10%     
==========================================
  Files         120      120              
  Lines        7343     7333      -10     
==========================================
+ Hits         4022     4024       +2     
+ Misses       2994     2984      -10     
+ Partials      327      325       -2     
Flag Coverage Δ
e2etests 37.31% <13.33%> (+0.02%) ⬆️
unittests 30.94% <63.33%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CorentinB CorentinB requested a review from vbanos August 14, 2025 12:29
@CorentinB CorentinB merged commit 3de4c6e into internetarchive:main Aug 14, 2025
2 checks passed
@CorentinB CorentinB deleted the 1.25-modernize branch August 14, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants