Skip to content

Revert "Create rootContext and share with components"#436

Merged
NGTmeaty merged 1 commit intomainfrom
revert-435-rootContext
Aug 17, 2025
Merged

Revert "Create rootContext and share with components"#436
NGTmeaty merged 1 commit intomainfrom
revert-435-rootContext

Conversation

@yzqzss
Copy link
Copy Markdown
Collaborator

@yzqzss yzqzss commented Aug 17, 2025

Reverts #435


Reason: #435 (comment)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 17, 2025

Codecov Report

❌ Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.82%. Comparing base (3b6ab75) to head (c8342f1).
⚠️ Report is 102 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/controler/pipeline.go 55.55% 3 Missing and 1 partial ⚠️
internal/pkg/consul/consul.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   54.80%   54.82%   +0.01%     
==========================================
  Files         120      120              
  Lines        7320     7333      +13     
==========================================
+ Hits         4012     4020       +8     
- Misses       2983     2987       +4     
- Partials      325      326       +1     
Flag Coverage Δ
e2etests 37.31% <76.66%> (+0.04%) ⬆️
unittests 30.90% <13.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NGTmeaty NGTmeaty merged commit 57bdaae into main Aug 17, 2025
5 checks passed
@CorentinB
Copy link
Copy Markdown
Collaborator

Thanks!!

@CorentinB CorentinB deleted the revert-435-rootContext branch August 17, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants