Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
==========================================
- Coverage 54.87% 54.72% -0.16%
==========================================
Files 120 120
Lines 7333 7346 +13
==========================================
- Hits 4024 4020 -4
- Misses 2984 3000 +16
- Partials 325 326 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Considering it's a stat based on discarding, maybe the name should be more precise on that? I could imagine a random user who would read "CF Challenge count" and would think that it's the number of challenges Zeno solved or something like that. What do you think? |
CorentinB
reviewed
Aug 19, 2025
| []string{"project", "hostname", "version"}, | ||
| ), | ||
| cfMitigated: prometheus.NewGaugeVec( | ||
| prometheus.GaugeOpts{Name: config.Get().PrometheusPrefix + "cf_challenge_pages_seena", Help: "Total number of CF challenge pages seen"}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a relatively simple commit to add a counter for CF challenge pages. Part of #366 and will likely have some more stats coming soon :)