Skip to content

fix multiLogger data race#446

Merged
NGTmeaty merged 1 commit intomainfrom
fix/logger-data-race
Aug 22, 2025
Merged

fix multiLogger data race#446
NGTmeaty merged 1 commit intomainfrom
fix/logger-data-race

Conversation

@yzqzss
Copy link
Copy Markdown
Collaborator

@yzqzss yzqzss commented Aug 22, 2025

fix a data race found in #444.


Although this is a data race, it only occurs when the log component is shutting down, which is the last component to be shut down, so this bug does not actually affect Zeno's data integrity.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.45%. Comparing base (c8a6c40) to head (144aadc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   54.69%   55.45%   +0.76%     
==========================================
  Files         120      120              
  Lines        7345     7364      +19     
==========================================
+ Hits         4017     4084      +67     
+ Misses       3004     2956      -48     
  Partials      324      324              
Flag Coverage Δ
e2etests 37.17% <36.84%> (-0.01%) ⬇️
unittests 31.91% <100.00%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@NGTmeaty NGTmeaty merged commit 4cfce9f into main Aug 22, 2025
5 checks passed
@NGTmeaty NGTmeaty deleted the fix/logger-data-race branch August 22, 2025 21:04
@yzqzss yzqzss added the bug Something isn't working label Aug 22, 2025
CorentinB pushed a commit that referenced this pull request Aug 27, 2025
@yzqzss yzqzss added the GSoC label Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working GSoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants