Skip to content

Add support for Sentry#456

Merged
NGTmeaty merged 7 commits intomainfrom
add-sentry
Sep 1, 2025
Merged

Add support for Sentry#456
NGTmeaty merged 7 commits intomainfrom
add-sentry

Conversation

@NGTmeaty
Copy link
Copy Markdown
Collaborator

@NGTmeaty NGTmeaty commented Aug 29, 2025

Also fixes pyroscope for URL-scoped crawl. Closes #453

@NGTmeaty NGTmeaty requested review from Copilot and willmhowes August 29, 2025 20:36
@NGTmeaty NGTmeaty self-assigned this Aug 29, 2025
@NGTmeaty NGTmeaty added the enhancement New feature or request label Aug 29, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for Sentry error monitoring and reporting to the application. The change integrates the Sentry SDK to enable error tracking and performance monitoring.

  • Adds Sentry DSN configuration parameter to enable Sentry monitoring
  • Creates reusable initialization functions for both Pyroscope and Sentry
  • Integrates Sentry initialization into the application startup flow

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/pkg/config/config.go Adds SentryDSN configuration field
go.mod Adds sentry-go dependency
cmd/utils.go Creates shared initialization functions for Pyroscope and Sentry
cmd/get_url.go Integrates Sentry initialization into get_url command
cmd/get_hq.go Refactors to use shared Pyroscope function and adds Sentry initialization
cmd/get.go Adds sentry-dsn command line flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread cmd/utils.go Outdated
Comment thread cmd/get_hq.go Outdated
NGTmeaty and others added 3 commits August 29, 2025 16:38
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 1.66667% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.66%. Comparing base (7ba600c) to head (945a57d).
⚠️ Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
cmd/utils.go 0.00% 43 Missing ⚠️
cmd/get_url.go 0.00% 8 Missing and 2 partials ⚠️
cmd/get_hq.go 0.00% 5 Missing ⚠️
internal/pkg/stats/prometheus.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   55.86%   55.66%   -0.21%     
==========================================
  Files         128      129       +1     
  Lines        8053     8084      +31     
==========================================
+ Hits         4499     4500       +1     
- Misses       3182     3210      +28     
- Partials      372      374       +2     
Flag Coverage Δ
e2etests 38.90% <1.66%> (-0.14%) ⬇️
unittests 29.20% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

willmhowes
willmhowes previously approved these changes Aug 29, 2025
Copy link
Copy Markdown
Collaborator

@willmhowes willmhowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@NGTmeaty NGTmeaty merged commit fa6efe8 into main Sep 1, 2025
5 checks passed
@NGTmeaty NGTmeaty deleted the add-sentry branch September 1, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pyroscope can only be used with HQ

4 participants