Add GCC 12+ requirement documentation with Ada URL parser context#463
Add GCC 12+ requirement documentation with Ada URL parser context#463
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
- Coverage 56.25% 56.20% -0.05%
==========================================
Files 130 130
Lines 8037 8037
==========================================
- Hits 4521 4517 -4
- Misses 3157 3161 +4
Partials 359 359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: CorentinB <5089772+CorentinB@users.noreply.github.com>
|
@copilot explain in the README that we need CGO because of the Go bindings of Ada, the WHATWG URL parser https://github.com/ada-url/goada, and that we hopefully will move away from it for a pure Go alternative in the future. |
…uture plans Co-authored-by: CorentinB <5089772+CorentinB@users.noreply.github.com>
Updated the README to explain that CGO is needed for Go bindings to Ada (the WHATWG URL parser) via github.com/ada-url/goada, and added note about future plans to move to a pure Go alternative. Changes in commit 66be986. |
| The name Zeno comes from Zenodotus (Ζηνόδοτος), a Greek grammarian, literary critic, Homeric scholar, | ||
| and the first librarian of the Library of Alexandria. | ||
|
|
||
| ## Requirements |
There was a problem hiding this comment.
requirements for building
There was a problem hiding this comment.
Updated the section title from "Requirements" to "Requirements for Building" to clarify that these are specifically build requirements. Changes in commit bd25f88.
Co-authored-by: CorentinB <5089772+CorentinB@users.noreply.github.com>
Users attempting to build Zeno on Ubuntu 22 LTS (GCC 11) and Ubuntu 20 LTS (GCC 10) encounter compilation failures due to missing C++20 constexpr support in older GCC versions. The errors manifest as:
This occurs because the
ada-url/goadadependency requires C++20 constexpr features that were not available in GCC 11 and earlier versions.While the CI already handles this requirement by explicitly installing
g++-12, users were not informed about this prerequisite, leading to build failures on common LTS distributions.Changes made:
.github/copilot-instructions.mdto specify GCC 12+ for development documentationThe documentation now clearly informs users about build requirements upfront, preventing confusion and failed build attempts, while providing context about why the C++ dependency exists and that it's temporary.
Fixes #462.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.