Skip to content

Improve startPipeline error handling#481

Merged
NGTmeaty merged 1 commit intointernetarchive:mainfrom
vbanos:pipeline-panic
Sep 20, 2025
Merged

Improve startPipeline error handling#481
NGTmeaty merged 1 commit intointernetarchive:mainfrom
vbanos:pipeline-panic

Conversation

@vbanos
Copy link
Copy Markdown
Collaborator

@vbanos vbanos commented Sep 19, 2025

Return error and use panic only once in the controller.

This way its cleaner and it would be easier to use it in tests.

Relevant to: #473

Return error and use `panic` only once in the controller.

This way its cleaner and it would be easier to use it in tests.
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 8.33333% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.26%. Comparing base (0837f4d) to head (5508747).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/controler/pipeline.go 9.09% 18 Missing and 2 partials ⚠️
internal/pkg/controler/controler.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   56.42%   56.26%   -0.16%     
==========================================
  Files         130      130              
  Lines        8091     8104      +13     
==========================================
- Hits         4565     4560       -5     
- Misses       3161     3177      +16     
- Partials      365      367       +2     
Flag Coverage Δ
e2etests 40.57% <8.33%> (-0.08%) ⬇️
unittests 29.28% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@NGTmeaty NGTmeaty merged commit aed9705 into internetarchive:main Sep 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants