Return errors in config init instead of os.Exit#483
Merged
NGTmeaty merged 1 commit intointernetarchive:mainfrom Sep 20, 2025
Merged
Return errors in config init instead of os.Exit#483NGTmeaty merged 1 commit intointernetarchive:mainfrom
NGTmeaty merged 1 commit intointernetarchive:mainfrom
Conversation
Config already returns errors and terminates when there is an issue. There is no need to use `os.Exit(1)` for these specific cases, return error and the program will terminate anyway where `config.InitConfig` is invoked if it gets an error.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
+ Coverage 56.42% 56.47% +0.05%
==========================================
Files 130 130
Lines 8091 8089 -2
==========================================
+ Hits 4565 4568 +3
+ Misses 3161 3155 -6
- Partials 365 366 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NGTmeaty
reviewed
Sep 19, 2025
Collaborator
NGTmeaty
left a comment
NGTmeaty
left a comment
There was a problem hiding this comment.
Looks good besides the one comment!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config already returns errors and terminates when there is an issue. There is no need to use
os.Exit(1)for these specific cases, return error and the program will terminate anyway whereconfig.InitConfigis invoked if it gets an error.Relevant to: #473