Merged
Conversation
Previously, when we had an item error we returned `fmt.Errorf("item is fresh but has children")`.
and then in the unit tests we had to use
`expected: errors.New("item is fresh but has children"`
There is no need to define an error multiple times. We define:
```
ErrItemFreshHasChildren = errors.New("item is fresh but has children")
```
and then use `ErrItemFreshHasChildren` everywhere.
This way, we can easily change the error text in one place and avoid
breaking the unit tests.
Also, we could avoid doing error string comparison and use `errors.Is`
but we can't do it right now because the tests have some special error
cases and its not straightforward.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
==========================================
- Coverage 56.42% 56.33% -0.09%
==========================================
Files 130 130
Lines 8091 8091
==========================================
- Hits 4565 4558 -7
- Misses 3161 3167 +6
- Partials 365 366 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when we had an item error we returned
fmt.Errorf("item is fresh but has children"). and then in the unit tests we had to useexpected: errors.New("item is fresh but has children"There is no need to define an error multiple times. We define:
and then use
ErrItemFreshHasChildreneverywhere.This way, we can easily change the error text in one place and avoid breaking the unit tests.
Also, we could avoid doing error string comparison and use
errors.Isbut we can't do it right now because the tests have some special error cases and its not straightforward.