Optimise encodeNonUTF8QueryURLs#485
Merged
NGTmeaty merged 1 commit intointernetarchive:mainfrom Sep 19, 2025
Merged
Conversation
Two optimisations: We iterate query `key` -> `values` and then iterate each `value` in `values`. We encoded the `key` again and again for each `value`. We only need to do it once. We move the key encoding code outside the `values` loop. We define `enc.NewEncoder().String()` every time we need to encode a value. We can define `encoder := enc.NewEncoder()` in the beginning and reuse it. We add a unit test for a bad URL just to be sure.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
- Coverage 56.42% 56.39% -0.03%
==========================================
Files 130 130
Lines 8091 8096 +5
==========================================
+ Hits 4565 4566 +1
- Misses 3161 3164 +3
- Partials 365 366 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NGTmeaty
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two optimisations:
We iterate query
key->valuesand then iterate eachvalueinvalues. We encoded thekeyagain and again for eachvalue. We only need to do it once. We move the key encoding code outside thevaluesloop.We define
enc.NewEncoder().String()every time we need to encode a value. We can defineencoder := enc.NewEncoder()in the beginning and reuse it.We add a unit test for a bad URL just to be sure.